-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Tag bundles and ignore them in uglify task #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
tag-bundles
branch
from
October 22, 2020 15:39
b4c16a7
to
d33b9f6
Compare
matz3
requested changes
Nov 2, 2020
lib/tasks/bundlers/generateBundle.js
Outdated
@@ -29,8 +32,11 @@ module.exports = function({workspace, dependencies, options: {projectName, bundl | |||
}, | |||
resources | |||
}).then((bundles) => { | |||
bundles.forEach((bundle) => { | |||
workspace.write(bundle); | |||
return bundles.map((bundle) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't Promise.all
missing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
matz3
approved these changes
Nov 2, 2020
RandomByte
added a commit
that referenced
this pull request
Nov 10, 2021
Seems like an oversight in #535. The tag can already be used and should be documented in the API reference
RandomByte
added a commit
that referenced
this pull request
Nov 10, 2021
Seems like an oversight in #535. The tag can already be used and should be documented in the API reference
RandomByte
added a commit
that referenced
this pull request
Nov 16, 2021
Seems like an oversight in #535. The tag can already be used and should be documented in the API reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.